Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url constructor import asset no as url #9399

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jul 27, 2022

Description

fix: #9309

add as: url for new URL('...', import.meta.url)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho poyoho added the bug label Jul 27, 2022
@poyoho poyoho changed the title fix: import meta url js no as url fix: url constructor import asset no as url Jul 27, 2022
@patak-dev patak-dev merged commit 122c6e7 into vitejs:main Jul 28, 2022
@poyoho poyoho deleted the fix/dynamic-import-url-js branch July 28, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new URL(url, import.meta.url) pattern broken for javascript modules in production
3 participants